Working on storage snippets

[daspecster]

Reference: https://github.com/daspecster/google-cloud-python/blob/add-storage-snippets/docs/storage_snippets.py

A few questions I have...

1. Should I make a PR to merge in at this point since we're not currently running snippets AFAICT?
2. If we're running these as system tests(which makes sense to me), I'm not sure how to handle things like email addresses for users and other account information(example).
3. If I should make mocks instead of hitting the service, it seems like that defeats the purpose unless I can inherit from the real class and just override the methods or some similar strategy?

[dhermes]

1. Yes
2. "If we're running these as system tests" --> then run them like the storage system tests. Does adding a "fake address" like 'me@example.org' work? If not, create a variable user_address outside the snippet and then just put acl.user(user_address).grant_read() inside the snippet.
3. @tseaver Has more opinions on this than I do.

[daspecster]

"If we're running these as system tests" --> then run them like the storage system tests. Does adding a "fake address" like 'me@example.org' work? If not, create a variable user_address outside the snippet and then just put acl.user(user_address).grant_read() inside the snippet.

I looked at the storage system tests and those didn't seem to test the ACL settings. The fake address didn't work as it's not a valid user when testing against live data.

Wouldn't making the user_address variable make the snippet less readable?

[dhermes]

Wouldn't making the user_address variable make the snippet less readable?

I don't think so, but maybe. If you think it does, you could

• modify the grant that was added after the snippet to make sure you use a valid email address
• find a valid email address that is "public domain", e.g. cloud-logs@google.com