chore(x-goog-spanner-request-id): commit foundation #3643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
google-cloud-spanner/src/main/java/com/google/cloud/spanner/XGoogSpannerRequestId.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/XGoogSpannerRequestId.java
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/XGoogSpannerRequestId.java
Outdated
Show resolved
Hide resolved
odeke-em
force-pushed
the
x-goog-request-id-bases
branch
from
5183b3c to
5f27364
Compare
|
@sakthivelmanii thanks for the first round of comments! I've addressed them, please take a look and also kindly help me run the bots. |
google-cloud-spanner/src/main/java/com/google/cloud/spanner/XGoogSpannerRequestId.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/XGoogSpannerRequestId.java
Outdated
Show resolved
Hide resolved
odeke-em
force-pushed
the
x-goog-request-id-bases
branch
from
643f345 to
bb9fdcf
Compare
|
@odeke-em mark this PR as chore. feat creates a new minor version. This change really does nothing. In upcoming PRs where you are using this class, you can define it as feat. |
|
thank you @sakthivelmanii I didn't know that about automatically creating releases: today I learnt! |
odeke-em
changed the title
olavloite
reviewed
Feb 14, 2025
google-cloud-spanner/src/main/java/com/google/cloud/spanner/XGoogSpannerRequestId.java
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/XGoogSpannerRequestId.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/XGoogSpannerRequestId.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/XGoogSpannerRequestId.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/XGoogSpannerRequestId.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/XGoogSpannerRequestId.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/XGoogSpannerRequestIdTest.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/XGoogSpannerRequestIdTest.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/XGoogSpannerRequestIdTest.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/XGoogSpannerRequestIdTest.java
Outdated
Show resolved
Hide resolved
odeke-em
force-pushed
the
x-goog-request-id-bases
branch
2 times, most recently
from
85ab665 to
8bd366d
Compare
|
@sakthivelmanii @olavloite thanks for the reviews, please take another round. |
odeke-em
force-pushed
the
x-goog-request-id-bases
branch
from
ccda785 to
c084579
Compare
rahul2393
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
olavloite
reviewed
Feb 16, 2025
google-cloud-spanner/src/main/java/com/google/cloud/spanner/XGoogSpannerRequestId.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/XGoogSpannerRequestId.java
Outdated
Show resolved
Hide resolved
| @RunWith(JUnit4.class) | ||
| public class XGoogSpannerRequestIdTest { | ||
| private static final Pattern REGEX_RAND_PROCESS_ID = | ||
| Pattern.compile("1.([0-9a-z]{16})(\\.\\d+){3}\\.(\\d+)$"); |
There was a problem hiding this comment.
The process ID should be a 32-bit unsigned number, so length 8 in hex format:
Suggested change
| Pattern.compile("1.([0-9a-z]{16})(\\.\\d+){3}\\.(\\d+)$"); | |
| Pattern.compile("1.([0-9a-z]{8})(\\.\\d+){3}\\.(\\d+)$"); |
There was a problem hiding this comment.
@olavloite we had a long discussion with Simil and team in the same group that you are, about why it should be 64-bits due to higher collisions if it were 32-bits per https://orijtech.notion.site/x-goog-spanner-request-id-always-on-gRPC-header-to-aid-in-quick-debugging-of-errors-14aba6bc91348091a58fca7a505c9827#14aba6bc9134807f9f17d3ef58e26128
olavloite
approved these changes
Feb 16, 2025
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This change adds in the bases to bring in the functionality for the "x-goog-spanner-request-id" that'll be used for debugging without the limits of trace continuity and sampling. Updates googleapis#3537 Address code review comments
odeke-em
force-pushed
the
x-goog-request-id-bases
branch
from
0a14334 to
331e06e
Compare
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds in the bases to bring in the functionality for the "x-goog-spanner-request-id" that'll be used for debugging without the limits of trace continuity and sampling.
Updates #3537