Skip to content

fix: add default implementations for Interval methods in AbstractStructReader #3722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025
Merged

fix: add default implementations for Interval methods in AbstractStructReader #3722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0cf525
fix: Provide default implementations for Interval methods in Abstract…
Apr 1, 2025
588ab30
addressed PR comments
Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions google-cloud-spanner/clirr-ignored-differences.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,16 +597,6 @@
<className>com/google/cloud/spanner/StructReader</className>
<method>java.util.List getIntervalList(java.lang.String)</method>
</difference>
<difference>
<differenceType>7013</differenceType>
<className>com/google/cloud/spanner/AbstractStructReader</className>
<method>com.google.cloud.spanner.Interval getIntervalInternal(int)</method>
</difference>
<difference>
<differenceType>7013</differenceType>
<className>com/google/cloud/spanner/AbstractStructReader</className>
<method>java.util.List getIntervalListInternal(int)</method>
</difference>
<difference>
<differenceType>7013</differenceType>
<className>com/google/cloud/spanner/Value</className>
Expand Down
8 changes: 6 additions & 2 deletions google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractStructReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,9 @@ protected String getPgJsonbInternal(int columnIndex) {

protected abstract Date getDateInternal(int columnIndex);

protected abstract Interval getIntervalInternal(int columnIndex);
protected Interval getIntervalInternal(int columnIndex) {
throw new UnsupportedOperationException("Not implemented");
}

protected <T extends AbstractMessage> T getProtoMessageInternal(int columnIndex, T message) {
throw new UnsupportedOperationException("Not implemented");
Expand Down Expand Up @@ -130,7 +132,9 @@ protected List<String> getPgJsonbListInternal(int columnIndex) {

protected abstract List<Date> getDateListInternal(int columnIndex);

protected abstract List<Interval> getIntervalListInternal(int columnIndex);
protected List<Interval> getIntervalListInternal(int columnIndex) {
throw new UnsupportedOperationException("Not implemented");
}

protected abstract List<Struct> getStructListInternal(int columnIndex);

Expand Down
Loading