chore: add x-goog-request-id insertion into *Exception #3813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
odeke-em
force-pushed
the
x-goog-request-id-base
branch
from
6ab4f05 to
4d3f093
Compare
product-auto-label
bot
added
size: l
rahul2393
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
odeke-em
force-pushed
the
x-goog-request-id-base
branch
from
f9eb16b to
b91b415
Compare
rahul2393
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
odeke-em
force-pushed
the
x-goog-request-id-base
branch
from
b91b415 to
a4dd421
Compare
|
@rahul2393 kindly help me again as I had to rebase from the latest main |
rahul2393
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Allows users to examine and report the requestId in any thrown exceptions. Updates googleapis#3537
odeke-em
force-pushed
the
x-goog-request-id-base
branch
from
a4dd421 to
ae29724
Compare
product-auto-label
bot
added
size: m
rahul2393
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
sakthivelmanii
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
olavloite
approved these changes
Apr 15, 2025
| Exception exc = new StatusRuntimeException(status); | ||
| SpannerException spannerExceptionWithReqId = | ||
| SpannerExceptionFactory.newSpannerException(exc, reqIdIn); | ||
| assertThat(spannerExceptionWithReqId.getRequestId()).isEqualTo(reqIdIn.toString()); |
There was a problem hiding this comment.
nit, for following pull requests: Please prefer the use of standard JUnit assertEquals(expected, actual) over assertThat, even when the test class in question uses assertThat.
There was a problem hiding this comment.
Got it and thank you @olavloite.
olavloite
added
the
automerge
gcf-merge-on-green
bot
merged commit c102cb4
into
googleapis:main
31 of 32 checks passed
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to examine and report the requestId in any thrown exceptions.