fix: allow string encryption keys #1418
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1418 +/- ##
=======================================
Coverage 99.10% 99.10%
=======================================
Files 14 14
Lines 12145 12147 +2
Branches 529 531 +2
=======================================
+ Hits 12036 12038 +2
Misses 109 109
Continue to review full report at Codecov.
|
gcf-owl-bot bot
added a commit
that referenced
this pull request
Apr 14, 2022
…move configs to Node 12 (#1418) * build: make ci testing conditional on engines field in package.json, move configs to Node 12 Co-authored-by: Benjamin E. Coe <[email protected]> Source-Link: googleapis/synthtool@2800f5a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:dc7bfb4c4bf50496abbdd24bd9e4aaa833dc75248c0a9e3a7f807feda5258873
ddelgrosso1
pushed a commit
that referenced
this pull request
Apr 15, 2022
…move configs to Node 12 (#1418) (#1874) * build: make ci testing conditional on engines field in package.json, move configs to Node 12 Co-authored-by: Benjamin E. Coe <[email protected]> Source-Link: googleapis/synthtool@2800f5a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:dc7bfb4c4bf50496abbdd24bd9e4aaa833dc75248c0a9e3a7f807feda5258873 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Benjamin E. Coe <[email protected]>
ddelgrosso1
pushed a commit
to ddelgrosso1/nodejs-storage
that referenced
this pull request
Apr 19, 2022
…move configs to Node 12 (googleapis#1418) (googleapis#1874) * build: make ci testing conditional on engines field in package.json, move configs to Node 12 Co-authored-by: Benjamin E. Coe <[email protected]> Source-Link: googleapis/synthtool@2800f5a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:dc7bfb4c4bf50496abbdd24bd9e4aaa833dc75248c0a9e3a7f807feda5258873 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Benjamin E. Coe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** edit ** I don't know if this was the right thing to do. Holding off for now.
The
encryptionKeyofbucket.upload({encryptionKey}),bucket.file('name', {encryptionKey}), and possibly others were said to accept either a String or Buffer. However, if a base64 string was provided, it was being re-encoded. This change will allow both to be handled separately, passing along the correct base64-encoded encryption key to the API.