fix: implement setMetadata in HmacKey and fix associated tests #2009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
conformance-test/libraryMethods.ts
Outdated
| @@ -680,8 +680,8 @@ export async function deleteHMAC(options: ConformanceTestOptions) { | |||
| const metadata = { | |||
| state: 'INACTIVE', | |||
| }; | |||
| options.hmacKey!.setMetadata(metadata); | |||
| await options.hmacKey!.delete(); | |||
| await hmacKey.setMetadata(metadata); | |||
There was a problem hiding this comment.
does this not run into the problem where the instructions get used here?
There was a problem hiding this comment.
It does not. I spoke with Cathy and verified in testing that only the delete call will utilize instruction count.
There was a problem hiding this comment.
oh right because the instructions are on the method specified. this makes sense.
src/hmacKey.ts
Outdated
| optionsOrCallback: SetMetadataOptions | MetadataCallback, | ||
| cb?: MetadataCallback | ||
| ): Promise<SetMetadataResponse> | void { | ||
| // ETag preconditions are not currently supported so retries should be disabled |
There was a problem hiding this comment.
unless the retry strategy is RetryAlways, right? i made this mistake too in IAM, I will fix it now
ddelgrosso1
force-pushed
the
refactor-setmetadata
branch
from
9ab9528 to
7b59aa4
Compare
shaffeeullah
added a commit
that referenced
this pull request
Aug 10, 2022
…el (#1993) * test: updated conformance tests for precondition updates * fixed typo * updated functions to pass preconditions * removed IAM and HMAC test changes * implemented local preconditions for bucketmakeprivate * added preconditions to enableLogging * linted files * implemented more preconditions * general cleanup * implemented precondition on combine * added preconditions for copy and move * rename * removed tests for instance precondition where instance precondition is not supported * support preconditions for rotateencryptionkey * support set storage class * linted files * fixed tests * deleteLabels and setLabels * more precondition implementations * minor progress * fix(refactor): Simplify logic around disabling autoretry for setmetadata * setcorsconfiguration * set retention period * bucketSetStorageClass * fileMakePrivate * file set metadata * bucket set metadata * file delete * more precondition updates * precondition refactor * removed log statement * change delete labels signature * fix delete labels * fixed save multipart * put docker code back * linted files * docs and cleanup * refactored conformance tests * remove iam test from being in the conformance tests * linted files * put docker commands back * fixed combine retries * added comments * fix: implement setMetadata in HmacKey and fix associated tests (#2009) * fix: implement setMetadata in HmacKey and fix associated tests * fix merge problem, check idempotency strategy * retry based on idempotency strategy * linted file * Revert "retry based on idempotency strategy" This reverts commit 80909b5. * don't retry acl adds * changed HEAD request to GET request * fix(refactor): Add a call from file.delete to the parent class delete (#2014) * fix(refactor): Add a call from file.delete to the parent class delete * add delete to checked methods for conditionally idempotent file ops * fix: fix noResponseRetries so it respects reqOpts.maxRetries (#2015) * fix: fix noResponseRetries so it respects reqOpts.maxRetries * fix situation where err.code is actually a string during connection resets * log error type * removed passing functions * restored retryInvocationMap * added instance precondition back to insert * restored scenario 2 * restored all scenarios * linted files * Revert "linted files" This reverts commit d2cb27b. * removed logs Co-authored-by: Sameena Shaffeeullah <[email protected]> * fix: pass appropriate preconditions from enableLogging to setMetadata (#2018) * tests: remove callback waterfall from make bucket private system test (#2020) * tests: remove callback waterfall from make bucket private system test * cleaner implementation * moved done() * removed precondition from policyoptions * added retries for setPolicy * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * removed unused import Co-authored-by: Denis DelGrosso <[email protected]> Co-authored-by: Denis DelGrosso <[email protected]> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕