Skip to content
This repository was archived by the owner on Mar 12, 2025. It is now read-only.

Invalid dev version identifiers in setup.py #165

Closed
con-f-use opened this issue Jun 6, 2023 · 1 comment · Fixed by #166 or #167
Closed

Invalid dev version identifiers in setup.py #165

con-f-use opened this issue Jun 6, 2023 · 1 comment · Fixed by #166 or #167

Comments

@con-f-use
Copy link
Contributor

con-f-use commented Jun 6, 2023

There is a bunch of invalid version matchers in setup.py. PEP 440 states:
(edit: they are not, after all, invalid - it's just hidden in the PEP and distlib doesn't parse them correctly)

The canonical public version identifiers MUST comply with the following scheme:
[N!]N(.N)*[{a|b|rc}N][.postN][.devN]

So you are missing a dot and a number in every version identifier that contains the string dev.

It is also considered bad practice to have an upper bound on package versions and installers like pip do not typically consider development versions in any case (unless explicitly told to).

See: googleapis/google-api-python-client#2151

@con-f-use
Copy link
Contributor Author

Discussion in: googleapis/python-api-core#504

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant