fix: pin protobuf to < 3.18.0 #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #276 The latest versions of Cloud libraries (except for google-cloud-storage) have moved on to python >= 3.6. However, users of the storage library and older Cloud libraries may be impacted. protocolbuffers/protobuf#8984
google-cla
bot
added
the
cla: yes
|
docfx is unhappy but other sessions are OK: |
dandhlee
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #276. This PR is being made to the v1 branch and will be released manually in 1.31.3.
Protobuf 3.18.0 removed support for Python 2.7 and 3.5 https://github.com/protocolbuffers/protobuf/releases/tag/v3.18.0. Because the protobuf library does not use
python_requires, pip will try to install it even on Python 2.7. A new release ofgoogle-api-coreshould result in google-cloud-* library users getting the last version of protobuf they can use.The latest versions of Cloud libraries (except for google-cloud-storage) have moved on to python >= 3.6. However, users google-cloud-storage and older Cloud libraries may be impacted.
Also see protocolbuffers/protobuf#8984