Skip to content

feat: Add a little bit of typing to google.api_core.retry #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2023
Merged

feat: Add a little bit of typing to google.api_core.retry #453

merged 3 commits into from
Sep 1, 2023

Conversation

asottile-sentry
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea (N/A)
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary) (N/A)

@google-cla
Copy link

google-cla bot commented Sep 26, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Sep 26, 2022
@@ -54,13 +54,14 @@ def check_if_exists():

"""

from __future__ import unicode_literals
from __future__ import annotations
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this library has python_requires >= 3.7 so (1) unicode_literals does nothing and (2) this is the first version which supports __future__.annotations

it might be a good idea to run https://github.com/asottile/pyupgrade on this codebase to remove the remaining python 2isms

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've captured this TODO in #524

@asottile-sentry asottile-sentry marked this pull request as ready for review September 26, 2022 17:28
@asottile-sentry asottile-sentry requested review from a team as code owners September 26, 2022 17:28
@asottile-sentry
Copy link
Contributor Author

👋 I've rebased this to resolve conflicts (again) -- could it get reviewed?

@parthea parthea changed the title add a little bit of typing to google.api_core.retry feat: Add a little bit of typing to google.api_core.retry Aug 30, 2023
@parthea parthea self-assigned this Aug 30, 2023
parthea
parthea previously approved these changes Sep 1, 2023
Copy link
Collaborator

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -54,13 +54,14 @@ def check_if_exists():

"""

from __future__ import unicode_literals
from __future__ import annotations
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've captured this TODO in #524

@parthea parthea added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Sep 1, 2023
@gcf-merge-on-green gcf-merge-on-green bot dismissed parthea’s stale review September 1, 2023 14:02

This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.

@parthea parthea merged commit 2477ab9 into googleapis:main Sep 1, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Sep 1, 2023
@asottile-sentry asottile-sentry deleted the type-retry-a-bit branch September 5, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants