-
Notifications
You must be signed in to change notification settings - Fork 90
fix: fix test_repr assertion #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Stepping back: the intent appears to be to compare regardless of order, so it's more robust and cleaner to restructure the test to not have branches for possible orderings. |
I looked back at when this test was added, and read through the codebase better (based on your most recent feedback on my PR). Really, the goal of the test is to make sure that: def __repr__(self):
return "ClientOptions: " + repr(self.__dict__) Serializes the class with a |
python-api-core/tests/unit/test_client_options.py:
test_repr()
had an assertion that was alwaysTrue
.Fixes #449