-
Notifications
You must be signed in to change notification settings - Fork 90
fix: for backwards compatibility, expose legacy retry imports #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ffe7555
fix(WIP): for backwards compatibility, expose legacy retry imports
vchudnov-g 5bcd7a3
fix: add legacy imports to preserve backwards compatibility
vchudnov-g b25579e
reformat as requiired by prechecks
vchudnov-g febe8b8
Import individually
vchudnov-g 6e7e90b
fix: do not expose transitive imports purely for bw compatibility
vchudnov-g 1ad808e
Merge branch 'main' into retries-include
vchudnov-g f7b6337
remove cruft
vchudnov-g 7f542ec
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 821ebce
Update Copyright year
vchudnov-g File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
# Copyright 2023 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
|
||
def test_legacy_imports_retry_unary_sync(): | ||
# TODO: Delete this test when when we revert these imports on the | ||
# next major version release | ||
# (https://github.com/googleapis/python-api-core/issues/576) | ||
from google.api_core.retry import datetime_helpers # noqa: F401 | ||
from google.api_core.retry import exceptions # noqa: F401 | ||
from google.api_core.retry import auth_exceptions # noqa: F401 | ||
|
||
|
||
def test_legacy_imports_retry_unary_async(): | ||
# TODO: Delete this test when when we revert these imports on the | ||
# next major version release | ||
# (https://github.com/googleapis/python-api-core/issues/576) | ||
from google.api_core import retry_async # noqa: F401 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.