Skip to content

ci(v1): fix builds in v1 branch #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 13, 2024
Merged

ci(v1): fix builds in v1 branch #610

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f2e902
fix docs build
parthea Feb 13, 2024
af743c9
pin flake8
parthea Feb 13, 2024
7127e13
remove pin for pytest
parthea Feb 13, 2024
ad85a05
use pytest instead of py.test
parthea Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 29 additions & 7 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def lint(session):
Returns a failure if the linters find linting errors or sufficiently
serious code quality issues.
"""
session.install("flake8", BLACK_VERSION)
session.install("flake8==6.0.0", BLACK_VERSION)
session.install(".")
session.run(
"black",
Expand Down Expand Up @@ -97,9 +97,7 @@ def default(session, install_grpc=True):
session.install(
"dataclasses",
"mock",
# Revert to just "pytest" once
# https://github.com/pytest-dev/pytest/issues/10451 is fixed
"pytest<7.2.0",
"pytest",
"pytest-cov",
"pytest-xdist",
)
Expand All @@ -112,7 +110,7 @@ def default(session, install_grpc=True):
pytest_args = [
"python",
"-m",
"py.test",
"pytest",
*(
# Helpful for running a single test or testfile.
session.posargs
Expand Down Expand Up @@ -217,7 +215,20 @@ def docs(session):
"""Build the docs for this library."""

session.install("-e", ".[grpc]")
session.install("sphinx==4.2.0", "alabaster", "recommonmark")
session.install(
# We need to pin to specific versions of the `sphinxcontrib-*` packages
# which still support sphinx 4.x.
# See https://github.com/googleapis/sphinx-docfx-yaml/issues/344
# and https://github.com/googleapis/sphinx-docfx-yaml/issues/345.
"sphinxcontrib-applehelp==1.0.4",
"sphinxcontrib-devhelp==1.0.2",
"sphinxcontrib-htmlhelp==2.0.1",
"sphinxcontrib-qthelp==1.0.3",
"sphinxcontrib-serializinghtml==1.1.5",
"sphinx==4.5.0",
"alabaster",
"recommonmark",
)

shutil.rmtree(os.path.join("docs", "_build"), ignore_errors=True)
session.run(
Expand All @@ -240,7 +251,18 @@ def docfx(session):

session.install("-e", ".")
session.install(
"sphinx==4.0.1", "alabaster", "recommonmark", "gcp-sphinx-docfx-yaml"
# We need to pin to specific versions of the `sphinxcontrib-*` packages
# which still support sphinx 4.x.
# See https://github.com/googleapis/sphinx-docfx-yaml/issues/344
# and https://github.com/googleapis/sphinx-docfx-yaml/issues/345.
"sphinxcontrib-applehelp==1.0.4",
"sphinxcontrib-devhelp==1.0.2",
"sphinxcontrib-htmlhelp==2.0.1",
"sphinxcontrib-qthelp==1.0.3",
"sphinxcontrib-serializinghtml==1.1.5",
"gcp-sphinx-docfx-yaml",
"alabaster",
"recommonmark",
)

shutil.rmtree(os.path.join("docs", "_build"), ignore_errors=True)
Expand Down