[BUG] Don't load credentials from disk if reauth is True #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the credentials on disk are invalid, then `get_user_credentials()` may fail before it can fetch fresh credentials. Noticed first and fixed in pydata-google-auth package in pydata/pydata-google-auth@7ce7f3f Note about pydata-google-auth: eventually I'd like to move pandas-gbq to use that package for auth, but since I'm not sure when I'll have that package ready, I'm patching pandas-gbq, too.
👍 |
max-sixty
approved these changes
Sep 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the credentials on disk are invalid, then
get_user_credentials()may failbefore it can fetch fresh credentials.
Noticed first and fixed in pydata-google-auth package in
pydata/pydata-google-auth@7ce7f3f
Note about pydata-google-auth: eventually I'd like to move pandas-gbq
to use that package for auth, but since I'm not sure when I'll have that
package ready, I'm patching pandas-gbq, too.