Skip to content

BUG: fix AttributeError with BQ Storage API to download empty results #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 13, 2020

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Feb 12, 2020

Closes #299

Also:

  • Refactors timestamp helpers to their own file to help reduce the size of the gbq module.
  • Use bigquery_storage_v1beta1 module to avoid breaking when bigquery_storage_v1beta2 is released with breaking changes.

TODO:

  • Add tests to reproduce the issue.
  • Fix the issue.
  • Add to changelog.

Refactors timestamp helpers to their own file to help reduce the size of
the gbq module.
@tswast tswast changed the title WIP: fix empty df with bq storage API BUG: fix AttributeError with BQ Storage API to download empty results Feb 12, 2020
@tswast tswast marked this pull request as ready for review February 12, 2020 20:11
@tswast tswast merged commit e177978 into googleapis:master Feb 13, 2020
@tswast tswast deleted the issue299-empty-df branch February 13, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError when use_bqstorage_api=True on empty df
1 participant