-
Notifications
You must be signed in to change notification settings - Fork 125
fix: read_gbq
supports extreme DATETIME values such as 0001-01-01 00:00:00
#444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
933d470
fix: read out-of-bounds DATETIME values such as `0001-01-01 00:00:00`
tswast 9a9d3fd
feat: accepts a table ID, which downloads the table without a query
tswast 2a76982
revert tests for read_gbq fix which isn't yet resolved
tswast 4695c5f
Revert "revert tests for read_gbq fix which isn't yet resolved"
tswast 6adf233
add todo for next steps
tswast 73a791a
Merge remote-tracking branch 'upstream/main' into issue266-read_gbq-n…
tswast 9b1eb0d
add unit test for table ID read_gbq
tswast ec9ddaf
add helper for is_query
tswast 9cc7c74
implement read_gbq with table id
tswast dd51ad8
fix remaining tests, don't localalize out-of-bounds timestamp columns
tswast e1ad679
Update pandas_gbq/gbq.py
tswast d29bc2a
fix 3.7 unit tests
tswast cb8f24f
correct coverage
tswast 56b73b2
skip coverage for optional test skip
tswast 8a61e97
fix docs build
tswast 3f7900b
improve test coverage for error case
tswast ae3e044
Merge branch 'issue266-read_gbq-no-query' into issue365-extreme-datet…
tswast 3c53f1f
as of google-cloud-bigquery 1.11.0, get_table before list_rows is unn…
tswast c98982d
Merge branch 'issue266-read_gbq-no-query' into issue365-extreme-datet…
tswast f0acde6
refactor tests
tswast 362a26d
add more scalars
tswast 752d67c
add more types
tswast 5b46127
add failing time test
tswast 254f6a0
add test for bignumeric
tswast c0780b6
add test for null values
tswast 9aaedc6
add epoch timestamps to tests
tswast b03443b
add post-download dtype conversions
tswast cd6ae70
Merge remote-tracking branch 'upstream/main' into issue365-extreme-da…
tswast 11126a6
add failing test for desired fix
tswast 14e6070
fix the issue with extreme datetimes
tswast 8f92d9b
fix constraints
tswast 9985d15
fix tests for empty dataframe
tswast 6fb73a2
fix tests for older google-cloud-bigquery
tswast 8cc4524
ignore index on empty dataframe
tswast a0d6cad
add db-dtypes to runtime import checks
tswast dfa6942
Merge remote-tracking branch 'upstream/main' into issue365-extreme-da…
tswast 82c5362
document dependencies
tswast de4a06e
remove TODO, since done
tswast 9fc8c08
remove unnecessary special case for empty dataframe
tswast c5c0e85
remove redundant 'deprecated' from comment
tswast File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,10 +5,10 @@ | |
# | ||
# e.g., if setup.py has "foo >= 1.14.0, < 2.0.0dev", | ||
# Then this file should have foo==1.14.0 | ||
db-dtypes==0.3.0 | ||
google-auth==1.4.1 | ||
db-dtypes==0.3.1 | ||
google-auth==1.18.0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doesn't match the minimum constraint in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated |
||
google-auth-oauthlib==0.0.1 | ||
google-cloud-bigquery==1.11.1 | ||
google-cloud-bigquery==1.26.1 | ||
google-cloud-bigquery-storage==1.1.0 | ||
numpy==1.16.6 | ||
pandas==0.24.2 | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed for
date_as_object
parameter