Skip to content

tests: split out snippets builds #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 16, 2020
Merged

tests: split out snippets builds #219

merged 5 commits into from
Oct 16, 2020

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 10, 2020

@tmatsuo Emulating PR #207. I don't know if I'm missing anything: e.g., I don't quite understand what the split_system_tests=True does in the synth.py there.

Toward #191

@tseaver tseaver requested a review from tmatsuo August 10, 2020 19:25
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 10, 2020
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Aug 21, 2020
tmatsuo
tmatsuo reviewed Oct 2, 2020
View reviewed changes
Copy link
Contributor

@tmatsuo tmatsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply. Once we agree on the env var name, I can make a change for allowing the env var.

.kokoro/presubmit/presubmit.cfg Outdated
@@ -5,3 +5,7 @@ env_vars: {
key: "RUN_SYSTEM_TESTS"
value: "false"
}
env_vars: {
key: "RUN_SNIPPETS"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to allow this envvar in the Kokoro config in google3.
Also how about RUN_SNIPPETS_TESTS for consistensy?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RUN_SNIPPETS_TESTS sounds good to me

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to the Kokoro side configuration files.

@tswast tswast requested a review from a team October 16, 2020 19:37
@tswast tswast mentioned this pull request Oct 16, 2020
Merged
@tswast tswast added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 16, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 16, 2020
@gcf-merge-on-green
Copy link

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green
Copy link

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

tmatsuo
tmatsuo approved these changes Oct 16, 2020
View reviewed changes
.kokoro/presubmit/presubmit.cfg Outdated
@@ -5,3 +5,7 @@ env_vars: {
key: "RUN_SYSTEM_TESTS"
value: "false"
}
env_vars: {
key: "RUN_SNIPPETS"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to the Kokoro side configuration files.

@gcf-merge-on-green gcf-merge-on-green bot merged commit 29dd573 into master Oct 16, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 16, 2020
@tswast tswast deleted the 191-split-out-snippets-builds branch July 27, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmatsuo tmatsuo tmatsuo approved these changes

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @tmatsuo @tswast @yoshi-kokoro