Skip to content

test: drop per-language version coverage levels #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 29, 2020

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Feb 26, 2020

Closes #45.

This PR removes the magic coverage threshold values for individual unit test sessions, only the total cumulative coverage is retained.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut added api: bigquery Issues related to the googleapis/python-bigquery API. type: process A process-related concern. May include testing, release, or the like. testing labels Feb 26, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 26, 2020
@plamut plamut requested a review from tseaver March 2, 2020 08:16
dev_install = ".[all,fastparquet]"

session.install("-e", dev_install)
session.install("-e", ".[all,fastparquet]")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a side effect of resolving a merge conflict.

@plamut
Copy link
Contributor Author

plamut commented Mar 9, 2020

@tseaver Ping, a rubber stamp needed here. :)

@plamut plamut requested a review from shollyman March 25, 2020 11:01
@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 26, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 26, 2020
@plamut plamut merged commit deb68ff into googleapis:master Apr 29, 2020
@plamut plamut deleted the iss-45 branch April 29, 2020 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement. testing type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing: drop majyk coverage number: --cov-fail-under=97
4 participants