test: look for transaction info on child job, not parent job #978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquery
plamut
approved these changes
Sep 21, 2021
There was a problem hiding this comment.
So that was it? We might want to document that in the property's docstring?
Edit: And maybe also here in the product docs (it's not obvious that a parent job is not part of the multi-statement transaction, at least not to me 🙃 ).
That's the theory. According to a backend engineer "Script parent job is not part of the transaction started in the script. And a script can create multiple transactions, e.g., many Good idea, re: docstring. Added! |
plamut
approved these changes
Sep 21, 2021
|
Sent internal CL 397996384 for review to update the REST API docs. |
plamut
approved these changes
Sep 21, 2021
crwilcox
approved these changes
Sep 21, 2021
abdelmegahedgoogle
pushed a commit
to abdelmegahedgoogle/python-bigquery
that referenced
this pull request
Apr 17, 2023
…pis#978) * test: look for transaction info on child job, not parent job * clarify transaction_info docstring * use sphinx method directive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #975 🦕