Skip to content

fix: Add missing DocumentReference return value to .document #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: Add missing DocumentReference return value to .document #1052

wants to merge 1 commit into from

Conversation

jverkoey
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1051

@jverkoey jverkoey requested review from a team as code owners May 15, 2025 01:10
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 15, 2025
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label May 15, 2025
@jverkoey jverkoey changed the title Add missing DocumentReference return value to .document fix: Add missing DocumentReference return value to .document May 15, 2025
@jverkoey jverkoey closed this May 15, 2025
@jverkoey jverkoey requested a review from a team as a code owner May 15, 2025 02:16
@jverkoey jverkoey requested a review from briandorsey May 15, 2025 02:16
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xs Pull request size is extra small. labels May 15, 2025
@jverkoey jverkoey mentioned this pull request May 15, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandorsey briandorsey Awaiting requested review from briandorsey briandorsey is a code owner automatically assigned from googleapis/python-samples-reviewers

Assignees

@wu-hui wu-hui

Labels
api: firestore Issues related to the googleapis/python-firestore API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

google.cloud.firestore_v1.document.DocumentReference type missing from BaseCollectionReference
2 participants
@jverkoey @wu-hui