Skip to content

chore: remove local test_utils directory #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2020
Merged

chore: remove local test_utils directory #92

merged 1 commit into from
Apr 30, 2020

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Apr 29, 2020

Closes #91 🦕

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut added the type: cleanup An internal cleanup or hygiene concern. label Apr 29, 2020
@plamut plamut requested a review from pradn April 29, 2020 12:50
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 29, 2020
@pradn
Copy link
Contributor

pradn commented Apr 29, 2020

Can you explain what these are needed for? How does one install them from a git repo?

@plamut
Copy link
Contributor Author

plamut commented Apr 29, 2020 •
edited
Loading

@pradn In the PubSub lib system tests use the unique_resource_id helper from them (and some other libraries use even more stuff). These utils were available as a separate directory in the old monorepo, but that broke after the repo split. Having a local copy in each of the new repositories was a temporary workaround.

Test utils are now available in the common standalone repo, and I noticed that the noxfile already uses that, meaning that the local copy is not needed anymore.

@busunkim96 busunkim96 mentioned this pull request Apr 30, 2020
Merged
pradn
pradn approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@pradn pradn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks Peter!

@pradn pradn merged commit 607328b into googleapis:master Apr 30, 2020
@plamut plamut deleted the clean-test-utils branch April 30, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradn pradn pradn approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove test_utils directory
3 participants
@plamut @pradn @googlebot