django: implement DatabaseIntrospection.get_primary_key_column() and add get_relations() stub #320
Conversation
odeke-em
changed the title
timgraham
changed the title
odeke-em
force-pushed
the
get_table_relations+get_primary_key_columns
branch
from
65c6168 to
6a80eb3
Compare
| @@ -52,3 +52,48 @@ def get_table_description(self, cursor, table_name): | |||
| ) | |||
|
|
|||
| return descriptions | |||
|
|
|||
| def get_relations(self, cursor, table_name): | |||
| # TODO: PLEASE DO NOT USE THIS METHOD UNTIL | |||
There was a problem hiding this comment.
I have a slight preference for omitting this implementation for now (and instead return an empty dict) and add this code as part of #313 so the test can be enabled at the same time.
There was a problem hiding this comment.
The problem though is that digging up that code will require a context switch back and given the amount of time it took for me to dig through those docs I'd rather have it in here but with that warning, and not risk mistakenly going back to investigate again tediously. It'll return {} anyways.
There was a problem hiding this comment.
I don't think either of us would forget. Just put the method in a comment on #313. Going to have to edit the comment anyway. Your choice.
There was a problem hiding this comment.
Thank you for the input! Given the amount of time that I spent going back into re-investigating the DATE->TIMESTAMP conversions, I am now wary about my ability to recover code that had been previously posted up, so for that I shall just merge this as is.
…elations Implemented: * DatabaseIntrospection.get_primary_key_column * DatabaseIntrospection.get_relations However, get_relations tests CANNOT yet be enabled because Cloud Spanner doesn't yet have ON DELETE cascading for FOREIGN KEYS which limits #313, which renders the method useless as it will always return {} instead of being populated with values that are derived from FOREIGN KEYs. Fixes #312 Updates #311
odeke-em
force-pushed
the
get_table_relations+get_primary_key_columns
branch
from
6a80eb3 to
9ca5262
Compare
| @@ -52,3 +52,48 @@ def get_table_description(self, cursor, table_name): | |||
| ) | |||
|
|
|||
| return descriptions | |||
|
|
|||
| def get_relations(self, cursor, table_name): | |||
| # TODO: PLEASE DO NOT USE THIS METHOD UNTIL | |||
There was a problem hiding this comment.
I don't think either of us would forget. Just put the method in a comment on #313. Going to have to edit the comment anyway. Your choice.
|
Thank you for the review @timgraham! |
Implemented:
However, get_relations tests CANNOT yet be enabled because
Cloud Spanner doesn't yet have ON DELETE cascading for
FOREIGN KEYS which limits #313, which renders the method
useless as it will always return {} instead of being populated
with values that are derived from FOREIGN KEYs.
Fixes #312
Updates #311