Skip to content

feat: tweak table dropping mechanism #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 18, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

import re

from sqlalchemy import types
from sqlalchemy import types, ForeignKeyConstraint
from sqlalchemy.engine.base import Engine
from sqlalchemy.engine.default import DefaultDialect
from sqlalchemy.sql.compiler import (
Expand Down Expand Up @@ -86,6 +86,35 @@ def visit_empty_set_expr(self, type_):
class SpannerDDLCompiler(DDLCompiler):
"""Spanner DDL statements compiler."""

def visit_drop_table(self, drop_table):
"""
Cloud Spanner doesn't let to drop table which has indexes
or foreign key constraints. Building several DDLs (separated
by semicolons) to drop indexes and foreign keys of the table
before actually executing DROP TABLE statement.

Args:
(sqlalchemy.schema.DropTable): DROP TABLE statement object.

Returns:
str:
DDLs separated by semicolons, which will sequentially
drop indexes, foreign keys constraints and then the
table itself.
"""
constrs = ""
for cons in drop_table.element.constraints:
if isinstance(cons, ForeignKeyConstraint) and cons.name:
constrs += "ALTER TABLE {table} DROP CONSTRAINT {constr};".format(
table=drop_table.element.name, constr=cons.name
)

indexes = ""
for index in drop_table.element.indexes:
indexes += "DROP INDEX {};".format(index.name)

return indexes + constrs + str(drop_table)

def visit_primary_key_constraint(self, constraint):
"""Build primary key definition.

Expand Down