Skip to content

test: skip composite grouping tests #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2021
Merged

test: skip composite grouping tests #61

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00a8fed
test: skip composite grouping tests
Apr 27, 2021
27362af
Merge branch 'main' into composite_group_by
Apr 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/test_suite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@
from sqlalchemy.testing.suite.test_select import (
IsOrIsNotDistinctFromTest as _IsOrIsNotDistinctFromTest,
)
from sqlalchemy.testing.suite.test_select import OrderByLabelTest as _OrderByLabelTest
from sqlalchemy.testing.suite.test_types import BooleanTest as _BooleanTest
from sqlalchemy.testing.suite.test_types import IntegerTest as _IntegerTest
from sqlalchemy.testing.suite.test_types import _LiteralRoundTripFixture
Expand Down Expand Up @@ -823,6 +824,11 @@ class IsOrIsNotDistinctFromTest(_IsOrIsNotDistinctFromTest):
pass


@pytest.mark.skip("Spanner doesn't support composed GROUP BY")
class OrderByLabelTest(_OrderByLabelTest):
pass
Copy link
Contributor Author

@IlyaFaer IlyaFaer Apr 27, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is trying to do something like:

select col1 + col2
...
group by col1 + col2

Spanner however requires col1 and col2 to be grouped by or aggregated separately.



class BytesTest(_LiteralRoundTripFixture, fixtures.TestBase):
__backend__ = True

Expand Down