Skip to content

test: add a migration nox testing session #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 18, 2021
Merged

test: add a migration nox testing session #69

merged 3 commits into from
May 18, 2021

Conversation

IlyaFaer
Copy link
Contributor

@IlyaFaer IlyaFaer commented May 14, 2021 •
edited
Loading

Adding a test session with a minimal migration.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 14, 2021
@IlyaFaer IlyaFaer requested review from AVaksman and larkee May 14, 2021 08:39
@IlyaFaer
Copy link
Contributor Author

IlyaFaer commented May 14, 2021 •
edited
Loading

If something fails during the migration the whole nox session fails as well.

@IlyaFaer
Copy link
Contributor Author

IlyaFaer commented May 14, 2021 •
edited
Loading

Oh, that's something new

File "/home/circleci/project/.nox/migration_test/lib/python3.8/site-packages/alembic/ddl/impl.py", line 80, in get_by_dialect
    return _impls[dialect.name]
KeyError: 'spanner'

I didn't yet see such an error. Working on it...

larkee
larkee approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with Alembic but it LGTM 👍

@IlyaFaer IlyaFaer merged commit 352c113 into main May 18, 2021
@IlyaFaer IlyaFaer deleted the migrations_test branch May 18, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkee larkee larkee approved these changes

@AVaksman AVaksman Awaiting requested review from AVaksman

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IlyaFaer @larkee