-
Notifications
You must be signed in to change notification settings - Fork 32
test: add back emulator test workflow #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
6151d74
test: add back emulator test workflow
skuruppu 4170b4b
fix: create project for tests against emulator
skuruppu 35c9342
skip numeric
77dad33
Merge branch 'main' into add-github-actions
larkee b9a6d54
Revert "skip numeric"
5283379
fix
970fe5c
Merge branch 'add-github-actions' of https://github.com/cloudspannere…
c483fe1
fix: conflicts
AVaksman 6b8656f
chore: use dynamic instance_id
AVaksman 2d1bca5
fix: uncomment and fix noncol_idx_test_nopk test
HemangChothani b73d7bd
fix: add primary key to fix get_unique_constraints
HemangChothani 50b4d4f
Merge branch 'main' into add-github-actions
AVaksman 5207574
Merge branch 'main' into add-github-actions
575222a
Revert "fix"
7cd1fcd
Merge branch 'add-github-actions' of https://github.com/cloudspannere…
9d1d13e
Revert "Revert "fix""
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
on: | ||
push: | ||
branches: | ||
- main | ||
pull_request: | ||
name: SQLAlchemy Spanner dialect | ||
jobs: | ||
tests: | ||
runs-on: ubuntu-latest | ||
|
||
services: | ||
emulator-0: | ||
image: gcr.io/cloud-spanner-emulator/emulator:latest | ||
ports: | ||
- 9010:9010 | ||
|
||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v2 | ||
- name: Setup Python | ||
uses: actions/setup-python@v2 | ||
with: | ||
python-version: 3.8 | ||
- name: Install nox | ||
run: python -m pip install nox | ||
- name: Run SQLAlchemy tests | ||
run: nox | ||
env: | ||
SPANNER_EMULATOR_HOST: localhost:9010 | ||
GOOGLE_CLOUD_PROJECT: appdev-soda-spanner-staging | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think these should fail. The latest release of the emulator does support NUMERIC. See googleapis/nodejs-spanner#1358 where we enabled the tests on Node.js.