Skip to content

refactor: unused attribute in StreamedResultSet() class #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
IlyaFaer opened this issue Jul 6, 2020 · 0 comments · Fixed by #113
Closed

refactor: unused attribute in StreamedResultSet() class #110

IlyaFaer opened this issue Jul 6, 2020 · 0 comments · Fixed by #113
Assignees
@IlyaFaer
Labels
api: spanner Issues related to the googleapis/python-spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@IlyaFaer
Copy link
Contributor

IlyaFaer commented Jul 6, 2020

While studying StreamedResultSet() class it came to my attention that it includes _counter attribute which is never actually used (not event in unit tests). As it's protected, it seems to be intended for object internal use, not for users (users probably can just take len() or count results by themselves if they need).

Proposing to erase the property.

/cc @larkee for approval
@IlyaFaer IlyaFaer added api: spanner Issues related to the googleapis/python-spanner API. type: cleanup An internal cleanup or hygiene concern. labels Jul 6, 2020
@IlyaFaer IlyaFaer self-assigned this Jul 6, 2020
@hengfengli hengfengli added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Jul 7, 2020
@IlyaFaer IlyaFaer mentioned this issue Jul 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IlyaFaer IlyaFaer

Labels
api: spanner Issues related to the googleapis/python-spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove unused _count attribute from StreamedResultSet class MaxxleLLC/python-spanner
2 participants
@hengfengli @IlyaFaer