Skip to content

refactor: remove unused _count attribute from StreamedResultSet class #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2020
Merged

refactor: remove unused _count attribute from StreamedResultSet class #113

merged 2 commits into from
Jul 14, 2020

Conversation

IlyaFaer
Copy link
Contributor

Closes #110

@IlyaFaer IlyaFaer added api: spanner Issues related to the googleapis/python-spanner API. type: cleanup An internal cleanup or hygiene concern. labels Jul 13, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 13, 2020
@IlyaFaer IlyaFaer requested review from hengfengli and larkee July 13, 2020 17:05
@IlyaFaer IlyaFaer marked this pull request as ready for review July 13, 2020 17:05
@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 14, 2020
@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 14, 2020
@IlyaFaer IlyaFaer merged commit edfefc8 into googleapis:master Jul 14, 2020
@IlyaFaer IlyaFaer deleted the excess_arg branch July 14, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hengfengli hengfengli hengfengli approved these changes

@larkee larkee larkee approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: unused attribute in StreamedResultSet() class
5 participants
@IlyaFaer @hengfengli @larkee @googlebot @yoshi-kokoro