Skip to content

feat: add support for Point In Time Recovery (PITR) #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 22, 2021
Merged

feat: add support for Point In Time Recovery (PITR) #148

merged 8 commits into from
Feb 22, 2021

Conversation

larkee
Copy link
Contributor

@larkee larkee commented Oct 7, 2020 •
edited
Loading

Implements support for PITR.

With this functionality users will be able to:

  • set the retention period for their databases.
  • set version time of the database when creating a backup

Creating a backup with a specific version time is shown below:

backup = instance.backup(backup_id, expire_time=expire_time, version_time=version_time)
backup.create()

@larkee larkee added the api: spanner Issues related to the googleapis/python-spanner API. label Oct 7, 2020
@larkee larkee requested a review from thiagotnunes October 7, 2020 07:02
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 7, 2020
@larkee larkee added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 7, 2020
@larkee larkee marked this pull request as ready for review October 7, 2020 23:37
@larkee larkee requested review from a team as code owners October 7, 2020 23:37
@larkee larkee requested a review from dinagraves October 7, 2020 23:37
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 8, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 8, 2020
@larkee larkee removed the request for review from dinagraves October 8, 2020 04:21
thiagotnunes
thiagotnunes approved these changes Oct 18, 2020
View reviewed changes
Copy link
Contributor

@thiagotnunes thiagotnunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@larkee larkee force-pushed the pitr-support branch 2 times, most recently from fade85a to b41da25 Compare November 24, 2020 08:33
thiagotnunes
thiagotnunes reviewed Jan 27, 2021
View reviewed changes
@zoercai zoercai mentioned this pull request Jan 27, 2021
Merged
@thiagotnunes
Copy link
Contributor

LGTM

@thiagotnunes thiagotnunes changed the title feat: add support for PITR-lite feat: Point In Time Recovery (PITR) Feb 4, 2021
@thiagotnunes thiagotnunes mentioned this pull request Feb 4, 2021
Merged
@larkee larkee changed the title feat: Point In Time Recovery (PITR) feat: add support for Point In Time Recovery (PITR) Feb 4, 2021
larkee and others added 8 commits February 5, 2021 21:41
@larkee
feat: add PITR-lite support
abc0a5a
@larkee
fix: remove unneeded conversion for earliest_version_time
95f3267
@larkee
test: fix list_databases list comprehension
b3b05ad
@zoercai @larkee
feat: add support for PITR-lite backups (#1)
acc62a2 
* Backup changes

* Basic tests

* Add system tests

* Fix system tests

* Add retention period to backup systests
@larkee
style: fix lint errors
49e8367
@zoercai @larkee
test: fix failing backup system tests (#2)
74800a9 
* Remove unnecessary retention period setting

* Fix systests
@zoercai @larkee
Review changes (#3)
2d3f566 
* Remove unnecessary retention period setting

* Fix systests

* Review changes
@larkee
style: fix lint
d2579ed
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 5, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 5, 2021
@larkee larkee removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 22, 2021
@larkee larkee merged commit a082e5d into googleapis:master Feb 22, 2021
@larkee larkee mentioned this pull request Feb 22, 2021
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 23, 2021
@larkee
test: fix PITR restored database version time assertion (#238)
fd14b13 
This PR fixes the assertion to use `metadata.backup_info.version_time` instead of `metadata.backup_info.create_time`. It looks it was passing before the backend correctly supported it and I forgot to re-run the tests before merging #148 (whoops!) and so it is currently failing and preventing #205 from being merged:
https://source.cloud.google.com/results/invocations/8f0f5dab-1b35-4ce3-bb72-0ce9e79ab89d/targets/cloud-devrel%2Fclient-libraries%2Fpython%2Fgoogleapis%2Fpython-spanner%2Fpresubmit%2Fpresubmit/log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagotnunes thiagotnunes thiagotnunes approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@larkee @thiagotnunes @yoshi-kokoro @zoercai