-
Notifications
You must be signed in to change notification settings - Fork 98
feat: DB-API driver + unit tests #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we'll need a PR in https://github.com/googleapis/python-spanner-django to remove spanner_dbapi
and then coordinate releasees. We can follow up with tests for 2.x.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Just one concern about NUMERIC loss of precision.
🤖 I have created a release \*beep\* \*boop\* --- ## [2.0.0](https://www.github.com/googleapis/python-spanner/compare/v1.19.1...v2.0.0) (2020-11-11) ### ⚠ BREAKING CHANGES * migrate to v2.0.0 (#147) ### Features * DB-API driver + unit tests ([#160](https://www.github.com/googleapis/python-spanner/issues/160)) ([2493fa1](https://www.github.com/googleapis/python-spanner/commit/2493fa1725d2d613f6c064637a4e215ee66255e3)) * migrate to v2.0.0 ([#147](https://www.github.com/googleapis/python-spanner/issues/147)) ([bf4b278](https://www.github.com/googleapis/python-spanner/commit/bf4b27827494e3dc33b1e4333dfe147a36a486b3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
BREAKING CHANGE: DBAPI code was moved into python-spanner in googleapis/python-spanner#160. This change removes it from this repo and bumps the dependency on python-spanner to 2.0.0, the first released version to include DBAPI.
The DB-API driver refactored from python-spanner-django repository, prior to its beta-release.
Some additional changes have been made to skip unit tests found incompatible with Python 2.