fix(Build Cop): fix flaky detection, fix local dev #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
==========================================
- Coverage 87.51% 87.45% -0.07%
==========================================
Files 15 15
Lines 2684 2687 +3
Branches 266 268 +2
==========================================
+ Hits 2349 2350 +1
- Misses 322 324 +2
Partials 13 13
Continue to review full report at Codecov.
|
This was referenced Feb 25, 2020
yoshi-automation
added a commit
that referenced
this pull request
Apr 1, 2020
2706f4f commit 2706f4f Author: Tyler Bui-Palsulich <[email protected]> Date: Wed Feb 19 12:10:32 2020 -0500 fix(Build Cop): fix flaky detection, fix local dev (#296)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local development wasn't working because
buildcop.tsdoesn't have the Probot app as the default export. I found themain.tspattern in the Probot docs, adapted it for this, and it works.That local development was how I figured out the payload for labels was not correct, so issues were never detected as flaky.
Fixes #281 🦕