Skip to content

test: fix flaky HttpJsonDirectServerStreamingCallableTest.testOnResponseError #2444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2024
Merged

test: fix flaky HttpJsonDirectServerStreamingCallableTest.testOnResponseError #2444

merged 2 commits into from
Feb 7, 2024

Conversation

meltsufin
Copy link
Member

  • increase timeout from 2s to 30s to reduce the chance of DEADLINE_EXCEEDED before the NOT_FOUND message is received
  • keep separate low timeout for the testDeadlineExceededServerStreaming test
  • remove mockService reset to speedup tests, as it's no longer necessary

Fixes: #1842.

@meltsufin
test: fix flaky HttpJsonDirectServerStreamingCallableTest.testOnRespo…
3c37a60 
…nseError

* increase timeout from 2s to 30s to reduce the chance of DEADLINE_EXCEEDED before the NOT_FOUND message is received
* keep separate low timeout for the testDeadlineExceededServerStreaming test
* remove mockService reset to speedup tests, as it's no longer necessary

Fixes: #1842.
@meltsufin meltsufin requested a review from a team as a code owner February 7, 2024 02:25
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Feb 7, 2024
@meltsufin meltsufin requested a review from suztomo February 7, 2024 02:26
suztomo
suztomo approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the test with a heavy load and it passed.

@meltsufin meltsufin enabled auto-merge (squash) February 7, 2024 20:38
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@meltsufin meltsufin merged commit 564802b into main Feb 7, 2024
@meltsufin meltsufin deleted the gh-1842 branch February 7, 2024 20:50
@meltsufin meltsufin mentioned this pull request Feb 8, 2024
Closed
ddixit14 pushed a commit that referenced this pull request Feb 15, 2024
@meltsufin @ddixit14
test: fix flaky HttpJsonDirectServerStreamingCallableTest.testOnRespo…
7716446 
…nseError (#2444)

* increase timeout from 2s to 30s to reduce the chance of
DEADLINE_EXCEEDED before the NOT_FOUND message is received
* keep separate low timeout for the testDeadlineExceededServerStreaming
test
* remove mockService reset to speedup tests, as it's no longer necessary

Fixes: #1842.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gax-java(windows): HttpJsonDirectServerStreamingCallableTest.testOnResponseError- getCode()
2 participants
@meltsufin @suztomo