-
Notifications
You must be signed in to change notification settings - Fork 66
feat: Parser to consume the api-versioning value from proto #2630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
8772c51
9ec3531
3b35cd0
23f2ce7
255c6f3
1ddb284
0e8705d
8f1a131
f025a3f
1bc4d64
0b57b3e
a28a8e8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -470,6 +470,11 @@ public static List<Service> parseService( | |
} | ||
} | ||
|
||
if (serviceOptions.hasExtension(ClientProto.apiVersion)) { | ||
String apiVersion = serviceOptions.getExtension(ClientProto.apiVersion); | ||
serviceBuilder.setApiVersion(apiVersion); | ||
} | ||
Comment on lines
+473
to
+476
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit:
I believe the Service class can take a null or empty ApiVersion There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I had similar concerns at first. But I believe both null and empty are covered. (I'll create additional test cases in ParserTest for it). |
||
|
||
String serviceName = s.getName(); | ||
String overriddenServiceName = serviceName; | ||
String pakkage = TypeParser.getPackage(fileDescriptor); | ||
|
Uh oh!
There was an error while loading. Please reload this page.