Skip to content

chore: exclude prediction.proto #2775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2024
Merged

chore: exclude prediction.proto #2775

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions library_generation/generate_library.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,12 @@ case "${proto_path}" in
# and //google/cloud/oslogin/v1beta1:google-cloud-oslogin-v1-java
proto_files="${proto_files} google/cloud/oslogin/common/common.proto"
;;
"google/cloud/visionai/v1"*)
# this proto is excluded in //google/cloud/visionai/v1:google-cloud-visionai-v1-java
# we can remove this exclusion after cl/631529749 is submitted.
removed_proto="google/cloud/visionai/v1/prediction.proto"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this proto is removed from googleapis, is this logic going to no-op or error out?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the command in cloudtop and it doesn't error

(.venv) [hi on] joewa@joewa-linxu:~/workspace/sdk-platform-java$ removed=google/cloud/visionai/prediction.proto
(.venv) [hi on] joewa@joewa-linxu:~/workspace/sdk-platform-java$ proto_files="google/example/example.proto google/example/another_example.proto"
(.venv) [hi on] joewa@joewa-linxu:~/workspace/sdk-platform-java$ mod="${proto_files//${removed}/}"
(.venv) [hi on] joewa@joewa-linxu:~/workspace/sdk-platform-java$ echo  $?
0
(.venv) [hi on] joewa@joewa-linxu:~/workspace/sdk-platform-java$ echo $mod 
google/example/example.proto google/example/another_example.proto

proto_files="${proto_files//${removed_proto}/}"
;;
"google/rpc")
# this proto is excluded from //google/rpc:google-rpc-java
removed_proto="google/rpc/http.proto"
Expand Down
Loading