Skip to content

chore: generate common protos and iam if config or Dockerfile changed #3145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

chore: generate common protos and iam if config or Dockerfile changed #3145

wants to merge 4 commits into from

Conversation

JoeWang1127
Copy link
Collaborator

@JoeWang1127 JoeWang1127 commented Aug 30, 2024 •
edited
Loading

In this PR:

  • Generate common protos and iam if generation config or Dockerfile is changed.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Aug 30, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Aug 30, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
8.3% Duplication on New Code (required ≤ 3%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@JoeWang1127 JoeWang1127 marked this pull request as ready for review August 30, 2024 20:41
@JoeWang1127 JoeWang1127 deleted the chore/always-gen branch August 30, 2024 20:44
@JoeWang1127 JoeWang1127 mentioned this pull request Aug 30, 2024
Merged
JoeWang1127 added a commit that referenced this pull request Sep 3, 2024
@JoeWang1127
chore: re-generate when config or Dockerfile is changed (#3146)
fa7c808 
In this PR:
- Re-generate common protos and iam if generation config or Dockerfile
is changed.

I use #3145 to verify the change.
ldetmer pushed a commit that referenced this pull request Sep 17, 2024
@JoeWang1127 @ldetmer
chore: re-generate when config or Dockerfile is changed (#3146)
96e5c59 
In this PR:
- Re-generate common protos and iam if generation config or Dockerfile
is changed.

I use #3145 to verify the change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeli0 blakeli0 Awaiting requested review from blakeli0

@diegomarquezp diegomarquezp Awaiting requested review from diegomarquezp

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoeWang1127 @cloud-java-bot