Skip to content

chore: update base image to include tag #3409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

JoeWang1127
Copy link
Collaborator

@JoeWang1127 JoeWang1127 commented Dec 4, 2024

In this PR:

  • Include tag in base image.

Renovate Bot can update the image sha with a fixed tag (doc). Without the tag, the updated image maybe not what we want.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Dec 4, 2024
@JoeWang1127 JoeWang1127 marked this pull request as ready for review December 4, 2024 20:46
Copy link

sonarqubecloud bot commented Dec 4, 2024

Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@diegomarquezp
Copy link
Contributor

Nice, I wasn't aware we can both specify the hash and the tag. Thanks!

@JoeWang1127 JoeWang1127 merged commit 86d3d8c into main Dec 4, 2024
50 checks passed
@JoeWang1127 JoeWang1127 deleted the chore/update-base-image-tag branch December 4, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants