Skip to content

fix: graalvm missing build time class when using protobuf 4.x #3438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 6, 2024
Merged

fix: graalvm missing build time class when using protobuf 4.x #3438

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7a8364d
fix: in case of protobuf 4+ need to include protobuf.Runtime in class…
ldetmer Dec 6, 2024
8295d03
fix: in case of protobuf 4+ need to include protobuf.Runtime in class…
ldetmer Dec 6, 2024
16aa61e
fix: in case of protobuf 4+ need to include protobuf.Runtime in class…
ldetmer Dec 6, 2024
f0ec3b5
revert protobuf upgrade
ldetmer Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...a/gax/src/main/resources/META-INF/native-image/com.google.api/gax/native-image.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ Args = --enable-url-protocols=https,http \
org.junit.platform.engine.TestTag,\
com.google.api.gax.core.GaxProperties,\
com.google.common.base.Platform,\
com.google.common.base.Platform$JdkPatternCompiler \
com.google.common.base.Platform$JdkPatternCompiler,\
com.google.protobuf.RuntimeVersion \
Copy link
Collaborator

@blakeli0 blakeli0 Dec 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this class only exists in protobuf 4.x, if a customer overrides protobuf to 3.x, I'm assuming it is going to fail for them?
If that's the case, we need to have a different solution, because our SDK is now guaranteed to be compatible with both protobuf 3.x and 4.x.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Answered offline that it is not an issue because the classes are not going to be loaded if they don't exist.

--features=com.google.api.gax.nativeimage.OpenCensusFeature,\
com.google.api.gax.nativeimage.GoogleJsonClientFeature \
--add-modules=jdk.httpserver
Loading