Skip to content

chore: centralize graal 23 downstream updates #3674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2025
Merged

chore: centralize graal 23 downstream updates #3674

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1c0a09
chore: centralize graal 23 downstream updates
diegomarquezp Mar 4, 2025
d0af847
add native downstream checks
diegomarquezp Mar 10, 2025
de19c92
Revert "add native downstream checks"
diegomarquezp Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...a/gax/src/test/resources/META-INF/native-image/com.google.api/gax/native-image.properties
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test in local that the GraalVM tests in downstream libraries still pass without the native-image.properties
in their repos?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a list of local test results in the description. I ended up further adjusting the configuration, so thanks!

Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
Args=--initialize-at-build-time=java.lang.annotation.Annotation,\
org.junit.experimental.categories.Category,\
org.junit.experimental.categories.CategoryValidator,\
org.junit.Ignore,\
org.junit.runner.RunWith,\
org.junit.runners.model.FrameworkField,\
org.junit.validator.AnnotationValidator,\
org.junit.vintage.engine.discovery.FilterableIgnoringRunnerDecorator
Comment on lines +2 to +8
Copy link
Contributor

@lqiu96 lqiu96 Mar 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q,, Is this only adding the junit configs because junit contains the common config between all the deps?

It's been a while since my release, but I recall storage-nio required some custom configurations: https://github.com/googleapis/java-storage-nio/blob/97c3624ac7e375621d78c7eea10b00359d7971fd/google-cloud-nio/src/main/resources/META-INF/native-image/com/google/cloud/google-cloud-nio/native-image.properties#L7-L12

I think one missing from there is guava's com.google.common.collect.RegularImmutableList, but not sure if adding that would mess with other downstream repos

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch. I was not aware that changes in storage-nio were necessary as well.
It should not break other repos since declaring the classes twice produces no problem.
I'm currently testing storage-nio after moving the configs to gax.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the relevant config and raise a PR to be merged once this one is released: googleapis/java-storage-nio#1559

Loading