Skip to content
This repository was archived by the owner on Sep 8, 2021. It is now read-only.

Remove files built by webpack #6

Merged
merged 1 commit into from
Apr 29, 2016
Merged

Conversation

njj
Copy link
Contributor

@njj njj commented Apr 25, 2016

This PR updates the .gitignore to ignore the main.js file that is built by Webpack. Typically any scripts built by module loaders or task runners are ignored, as they can be created on the fly by developers.

@vkarpov15
Copy link
Collaborator

IMO keeping the compiled file is a good idea so people can start the repo immediately without building anything. The behavior that I'm trying to get is "npm install and npm start are sufficient to run everything" (although admittedly I haven't added the start script yet...)

@njj
Copy link
Contributor Author

njj commented Apr 25, 2016

Fair enough @vkarpov15, this just means that you will have to ensure you build this file on every change and subsequent commit.

@vkarpov15
Copy link
Collaborator

Yeah I'm not a huge fan of that TBH, but I also like to honor the contract that npm install + npm start is sufficient to be able to go to localhost:4000 and see a working site. What would you think about putting webpack in a postinstall or prestart script?

@vkarpov15 vkarpov15 merged commit 7b6753f into gothinkster:master Apr 29, 2016
@njj njj deleted the remove-built-js branch April 29, 2016 17:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants