Updated GithubActions to use JDK 17 #1817
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbertrand
approved these changes
May 20, 2025
|
Any reason not to jump to 21? |
No particular reason tbh. Just wanted to do a minimal update, but I'm happy to bump to 21 as well. Let's discuss in our sync. |
|
Superseded by #1826 (JDK 21) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated GithubActions to use JDK 17. This is a required change, required by the org.gradle.toolchains.foojay-resolver-convention plugin v1.0.0.
Without this, we either can't upgrade to the latest version of org.gradle.toolchains.foojay-resolver-convention, or we have failing builds as seen on the example resolver upgrade PR: #1816