Convention workflows are enhanced #1461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by gradle/develocity-actions |
clayburn
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the single-build convention workflows,
convention-develocity-gradle-pluginandconvention-develocity-maven-extension, with findings from working on theconvention-develocity-shared.Namely, removing
-Ddevelocity.url=https://ge.solutions-team.gradle.comfrom the build tool invocation and instead replacingdevelocity-samples.gradle.comwithge.solutions-team.gradle.comin the corresponding class, just as a real user would do. See #1394 and commit 7dda2b0 for more details.Additionally, I applied one suggestion by @bigdaz to leverage the
setup-gradleaction to configure the Gradle version, rather than using thewrappertask. See commit 6800afe for more details.