Skip to content

Invalid JVM version error message is handled in the scripts #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

erichaagdev
Copy link
Member

Adds specific error handling for an invalid JVM version. Other non-zero exit codes are treated as an unexpected error.

Testing

Below are all of the test cases I ran to verify these changes.

Running with -x and Java 8

$ java -version            
openjdk version "1.8.0_362"
$ ./03-validate-local-build-caching-different-locations.sh -r [email protected]:gradle/ge-solutions.git -p sample-projects/gradle/8.x/ge -t 'build' -x

This results in the following:

image

Running with -x, Java 8, and setting CLIENT_JAVA_HOME

$ java -version            
openjdk version "1.8.0_362"
$ CLIENT_JAVA_HOME="$JDK17" ./03-validate-local-build-caching-different-locations.sh -r [email protected]:gradle/ge-solutions.git -p sample-projects/gradle/8.x/ge -t 'build' -x

This results in the following:

image

Running with -x and Java 17

$ java -version
openjdk version "17.0.6" 2023-01-17
$ ./03-validate-local-build-caching-different-locations.sh -r [email protected]:gradle/ge-solutions.git -p sample-projects/gradle/8.x/ge -t 'build' -x                                 

This results in the following:

image

Adds specific error handling for an invalid JVM version. Other non-zero
exit codes are treated as an unexpected error.
Signed-off-by: Etienne Studer <[email protected]>
Copy link
Member

@etiennestuder etiennestuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erichaagdev erichaagdev merged commit 5d1f348 into sorin/consolidation Sep 6, 2023
@erichaagdev erichaagdev deleted the erichaagdev/invalid-jvm-error branch September 6, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants