Skip to content

Github actions access token migration #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

ribafish
Copy link
Member

  • Migrated GitHub actions gradle executions to access token auth
  • Migrated GitHub actions cross build tests of BVS env var access key to develocity naming

@ribafish ribafish requested a review from a team June 20, 2024 10:02
Copy link
Member

@jprinet jprinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -19,7 +19,7 @@ jobs:
distribution: 'adopt'
- name: Set up Gradle
uses: gradle/gradle-build-action@v3
with:
develocity-access-key: ${{ secrets.DV_SOLUTIONS_ACCESS_KEY }}
- name: Build with Gradle
run: ./gradlew build -i
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a change you introduced, but I'm wondering if logging at info level is necessary

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be removed.

@ribafish ribafish merged commit 9771392 into main Jun 26, 2024
5 checks passed
@ribafish ribafish deleted the gk/ghaAccessTokenMigration branch June 26, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants