Skip to content

Custom logic to transform common Develocity injection script is reverted #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

erichaagdev
Copy link
Member

Important

Will be merged when common Develocity injection script 1.1 is released.

This PR removes the custom logic introduced in #682 to migrate the common Develocity injection script to use gradle.startParameter.systemPropertiesArgs to read system properties, as the common Develocity injection script now uses it.

@erichaagdev erichaagdev requested review from etiennestuder and a team December 9, 2024 16:43
@erichaagdev erichaagdev self-assigned this Dec 9, 2024
Copy link
Member

@etiennestuder etiennestuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erichaagdev erichaagdev force-pushed the erichaagdev/enforce-url branch from 578d494 to 8be1229 Compare December 11, 2024 14:48
@erichaagdev erichaagdev force-pushed the erichaagdev/injection-script-sys-prop branch from ca060fa to e6991c9 Compare December 11, 2024 14:50
@erichaagdev erichaagdev marked this pull request as ready for review December 11, 2024 15:00
Base automatically changed from erichaagdev/enforce-url to main December 11, 2024 15:42
@erichaagdev erichaagdev merged commit 0e68f4d into main Dec 11, 2024
1 check passed
@erichaagdev erichaagdev deleted the erichaagdev/injection-script-sys-prop branch December 11, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants