Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --experiment-run-id argument when calling summary tool #817

Merged
merged 3 commits into from
Apr 11, 2025

Conversation

erichaagdev
Copy link
Member

@erichaagdev erichaagdev commented Mar 28, 2025

This PR updates the scripts to include the --experiment-run-id argument to the build scan summary tool when both build scans are published by the scripts. This makes it possible for the tool to fetch all build scan data at once. For this to work, both builds must have a common experiment run id.

image

In scenarios where there is no common run id, as is the case in experiments involving CI builds, only 2 calls are made.

image

Previously, a separate call was made for each required build model.

image

@erichaagdev erichaagdev self-assigned this Mar 28, 2025
@erichaagdev erichaagdev force-pushed the erichaagdev/use-query-arg branch from 0b1ec01 to 0e40ba6 Compare March 28, 2025 19:36
Calling the summary tool with the --query argument will allow all build
scan data to be fetched at once. This is possible when both build scans
are published during script execution. When that's not the case, the
--query argument is not used.
@erichaagdev erichaagdev force-pushed the erichaagdev/use-query-arg branch from 0e40ba6 to fcb4e20 Compare March 28, 2025 21:26
Base automatically changed from erichaagdev/more-random-id to main April 1, 2025 18:05
@erichaagdev erichaagdev changed the title Use --query argument when calling summary tool Use --experiment-run-id argument when calling summary tool Apr 1, 2025
@erichaagdev erichaagdev force-pushed the erichaagdev/use-query-arg branch from f536507 to 651a5d6 Compare April 10, 2025 19:36
@erichaagdev erichaagdev marked this pull request as ready for review April 10, 2025 19:36
@erichaagdev erichaagdev force-pushed the erichaagdev/use-query-arg branch from 4cada29 to e94efe8 Compare April 10, 2025 19:51
@erichaagdev
Copy link
Member Author

Here's a reference build scan with the removed third party dependencies. https://ge.solutions-team.gradle.com/s/3cm4thmi33bkg/dependencies

@erichaagdev erichaagdev merged commit 2902fcb into main Apr 11, 2025
4 checks passed
@erichaagdev erichaagdev deleted the erichaagdev/use-query-arg branch April 11, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants