Skip to content

chore: bumping go version 1.22 #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2024
Merged

chore: bumping go version 1.22 #396

merged 1 commit into from
Oct 14, 2024

Conversation

s4kh
Copy link
Contributor

@s4kh s4kh commented Oct 11, 2024

grafana/grafana-plugin-sdk-go#1107

Tests

Integration tests are passing.

@CLAassistant
Copy link

CLAassistant commented Oct 11, 2024

CLA assistant check
All committers have signed the CLA.

@s4kh s4kh force-pushed the chore-bump-go-version branch from 1adf8a9 to 4263039 Compare October 11, 2024 13:53
@s4kh s4kh marked this pull request as ready for review October 11, 2024 14:06
@s4kh s4kh requested review from a team as code owners October 11, 2024 14:06
@s4kh s4kh requested review from jackw, wbrowne, andresmgot, oshirohugo and marefr and removed request for a team October 11, 2024 14:06
@andresmgot
Copy link
Contributor

we probably need to update the version in the GH action too: https://github.com/grafana/grafana-plugin-examples/actions/runs/11293635621/workflow#L95 (to run tests with the new version)

@s4kh s4kh force-pushed the chore-bump-go-version branch from 4263039 to eb86313 Compare October 14, 2024 14:36
Copy link
Contributor

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Think that the toolchain directives in go.mod can be removed/doesn't do any difference with these changes, but not sure

@s4kh s4kh merged commit 1d4fdc9 into main Oct 14, 2024
20 checks passed
@s4kh s4kh deleted the chore-bump-go-version branch October 14, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants