Pass secret store from API #1179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d0ugal
force-pushed
the
pass-secret-store
branch
12 times, most recently
from
1930ca5 to
b180662
Compare
d0ugal
force-pushed
the
pass-secret-store
branch
from
b180662 to
4fcba0c
Compare
d0ugal
force-pushed
the
pass-secret-store
branch
7 times, most recently
from
032de68 to
2654b4f
Compare
d0ugal
force-pushed
the
pass-secret-store
branch
from
109bb41 to
5514598
Compare
|
This change depends on https://github.com/grafana/gsm-api-go-client/pull/1/files |
mem
reviewed
Mar 6, 2025
d0ugal
force-pushed
the
pass-secret-store
branch
from
5514598 to
b079816
Compare
mem
approved these changes
Mar 11, 2025
This is what the pending upstream change uses.
d0ugal
force-pushed
the
pass-secret-store
branch
from
b079816 to
5810b67
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses the new protobuf fields from #1192 and passes them down to the k6 executable.
This change requires quite a bit of plumbing to get the details in the right place.
It also includes a small refactor of local.go to make it easier to test the construction of the CLI args.