fix: Update version reporting logic #1244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mem
force-pushed
the
mem/update-version-reporting-logic
branch
from
f77b3f4 to
2d839f8
Compare
ka3de
approved these changes
Mar 10, 2025
mem
force-pushed
the
mem/update-version-reporting-logic
branch
from
2d839f8 to
c765218
Compare
ka3de
approved these changes
Mar 11, 2025
Go 1.24 added a way to obtain the version (extract from the current Git repo) from the running program. Switch to that instead of passing linker flags at build time. Update ./scripts/version to report the same string. Signed-off-by: Marcelo E. Magallon <[email protected]>
mem
force-pushed
the
mem/update-version-reporting-logic
branch
from
c765218 to
14421d4
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.24 added a way to obtain the version (extract from the current Git repo) from the running program. Switch to that instead of passing linker flags at build time.