chore: upgrade blackbox exporter #1255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d0ugal
force-pushed
the
bbe-upgrade
branch
3 times, most recently
from
0597821 to
834ded3
Compare
The logging framework changed so we need to introduce an adapter. Fixes #1238
d0ugal
commented
Apr 4, 2025
| @@ -31,7 +31,7 @@ probe_ip_protocol 4 | |||
| probe_ssl_earliest_cert_expiry 3.6e+09 | |||
| # HELP probe_ssl_last_chain_info Contains SSL leaf certificate information | |||
| # TYPE probe_ssl_last_chain_info gauge | |||
| probe_ssl_last_chain_info{fingerprint_sha256="efc04a3afb86376b3a4db1b1d2f454afc60d192a573d78541836d83e4c849813",issuer="O=Acme Co",subject="O=Acme Co",subjectalternative="example.com"} 1 | |||
| probe_ssl_last_chain_info{fingerprint_sha256="efc04a3afb86376b3a4db1b1d2f454afc60d192a573d78541836d83e4c849813",issuer="O=Acme Co",serialnumber="8a086bc8a70f8a416a58b6741a5cebec",subject="O=Acme Co",subjectalternative="example.com"} 1 | |||
d0ugal
commented
Apr 4, 2025
| # HELP probe_success Displays whether or not the probe was a success | ||
| # TYPE probe_success gauge | ||
| probe_success 1 | ||
| # HELP probe_tls_cipher_info Returns the TLS cipher negotiated during handshake | ||
| # TYPE probe_tls_cipher_info gauge | ||
| probe_tls_cipher_info{cipher="TLS_AES_128_GCM_SHA256"} 1 |
There was a problem hiding this comment.
Copilot reviewed 16 out of 30 changed files in this pull request and generated no comments.
Files not reviewed (14)
- go.mod: Language not supported
- internal/scraper/testdata/browser.txt: Language not supported
- internal/scraper/testdata/browser_basic.txt: Language not supported
- internal/scraper/testdata/dns.txt: Language not supported
- internal/scraper/testdata/dns_basic.txt: Language not supported
- internal/scraper/testdata/grpc.txt: Language not supported
- internal/scraper/testdata/grpc_basic.txt: Language not supported
- internal/scraper/testdata/grpc_ssl.txt: Language not supported
- internal/scraper/testdata/grpc_ssl_basic.txt: Language not supported
- internal/scraper/testdata/http.txt: Language not supported
- internal/scraper/testdata/http_basic.txt: Language not supported
- internal/scraper/testdata/http_ssl.txt: Language not supported
- internal/scraper/testdata/http_ssl_basic.txt: Language not supported
- internal/scraper/testdata/multihttp.txt: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logging framework changed so we need to introduce an adapter.
There are also a couple of metric changes (one new label and one new metric). So the test data was updated.
Fixes #1238