Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/grafana_alert_notification Add disable_resolve_message #145

Merged

Conversation

Puneeth-n
Copy link
Contributor

@Puneeth-n Puneeth-n commented Dec 4, 2020

closes #62

root@8321e8aa53b6:/go/src/github.com/terraform-providers/terraform-provider-grafana# make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v  -timeout 120m
?   	github.com/terraform-providers/terraform-provider-grafana	[no test files]
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccAlertNotification_basic
--- PASS: TestAccAlertNotification_basic (0.27s)
=== RUN   TestAccAlertNotification_disableResolveMessage
--- PASS: TestAccAlertNotification_disableResolveMessage (0.40s)
=== RUN   TestAccAlertNotification_invalid_frequence
--- PASS: TestAccAlertNotification_invalid_frequence (0.07s)
=== RUN   TestAccAlertNotification_reminder_no_frequence
--- PASS: TestAccAlertNotification_reminder_no_frequence (0.07s)
=== RUN   TestAccDashboard_basic
--- PASS: TestAccDashboard_basic (0.51s)
=== RUN   TestAccDashboard_folder
--- PASS: TestAccDashboard_folder (0.47s)
=== RUN   TestAccDashboard_disappear
--- PASS: TestAccDashboard_disappear (0.24s)
=== RUN   TestAccDataSource_basic
--- PASS: TestAccDataSource_basic (2.88s)
=== RUN   TestAccFolderPermission_basic
--- PASS: TestAccFolderPermission_basic (0.98s)
=== RUN   TestAccFolder_basic
--- PASS: TestAccFolder_basic (0.28s)
=== RUN   TestAccOrganization_basic
--- PASS: TestAccOrganization_basic (0.61s)
=== RUN   TestAccOrganization_users
--- PASS: TestAccOrganization_users (0.97s)
=== RUN   TestAccOrganization_defaultAdmin
--- PASS: TestAccOrganization_defaultAdmin (0.63s)
=== RUN   TestAccTeamPreferences_basic
--- PASS: TestAccTeamPreferences_basic (0.82s)
=== RUN   TestAccTeam_basic
--- PASS: TestAccTeam_basic (0.61s)
=== RUN   TestAccTeam_Members
--- PASS: TestAccTeam_Members (0.61s)
=== RUN   TestAccUser_basic
--- PASS: TestAccUser_basic (0.64s)
PASS
ok  	github.com/terraform-providers/terraform-provider-grafana/grafana	(cached)

@Puneeth-n Puneeth-n marked this pull request as ready for review December 4, 2020 14:33
@Puneeth-n
Copy link
Contributor Author

@dannykopping can you please review it?

Copy link
Member

@trotttrotttrott trotttrotttrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The grafana_alert_notification updates look good. Thanks for that.

I love the docker-compose work. I've been wanting to do something like this. It's this that I have a few comments on.

Copy link
Member

@trotttrotttrott trotttrotttrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@trotttrotttrott trotttrotttrott merged commit 31f2f7e into grafana:master Jan 26, 2021
@Puneeth-n Puneeth-n deleted the feature/disable_resolve_message branch January 26, 2021 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Support "sendReminder" and "frequency" options in the alert notification resource
2 participants