Permission Items: Common code #1471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
julienduchesne
force-pushed
the
julienduchesne/permission-item-common-code
branch
from
38a76ba to
7435d9d
Compare
K-Phoen
approved these changes
Apr 9, 2024
julienduchesne
force-pushed
the
julienduchesne/ds-permission-item
branch
from
39e09a2 to
2cbc58c
Compare
julienduchesne
force-pushed
the
julienduchesne/permission-item-common-code
branch
from
b5aec83 to
df51981
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1465 and #1470
Lots of the code is exactly the same since it's the same API. This PR puts it in a common struct so that other permissions resources will be easier to add
Some of this code will also be usable for the global permissions resources (the existing not-
_itemones)